-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLS12-381 signature verification #2106
Conversation
Oh yeah, MSRV for tests.. I forgot. |
dd6d5ac
to
2e1ad7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Some first thoughts, not a full review
8501cb6
to
868c49b
Compare
Well, we still need a good metric as how to judge point aggregations. @webmaster128 any ideas about this? |
The point aggregations are a list of sums. Aggregating As we execute them in parallel, we get machine-specific performance. It would be good to measure using only a small number of cores (let's say 4) and assume production systems usually perform better. To benchmark this we can calculate |
15bb41d
to
205b8c3
Compare
2134266
to
b77e03c
Compare
So about the mismatch of the benchmarks in CI and the values in the environment: The benches for that were run locally by me. But it was run as follows:
So it wasn't run with the full horse-power of the CPU parallelism, but with the full clock speed. The differences are probably clock speed and parallelism (since IIRC the CircleCI medium class only has two cores instead of 4). But we can pretty much assume that production environment processors will be at least as fast as the Ryzen with 4 cores utilized IMO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice. I did not read it all yet, but some comments for today
Co-authored-by: Simon Warta <[email protected]>
Co-authored-by: Simon Warta <[email protected]>
…ty_lhs Add test pairing_equality_works_for_empty_lhs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐎🐎🐎🐎🐎🐎🐎
Closes #2094
This PR adds common BLS12-381 operations as VM intrinsics.